Add sys_getopt_r, sys_getopt_long_r and sys_getopt_long_only_r #99934
+362
−373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
JarmouniA,
MaochenWang1,
aaronemassey,
asemjonovs,
carlescufi,
erwango,
jakub-uC,
jeremybettis,
jfischer-no,
krish2718,
nashif,
pdgendt,
peter-mitsis,
ycsin and
yperess
Add sys_getopt_r, sys_getopt_long_r and sys_getopt_long_only_r variants of the getopt APIs. This allows applications to explicitly control their getopt state, rather than storing it in global and/or thread local variables. The existing APIs remain available and operate as they did before. Signed-off-by: Keith Packard <[email protected]>
The POSIX implementation of getopt should not expose any non-POSIX interfaces; applications needing Zephyr-compatible APIs should use the sys_getopt APIs. To make these testable, a minor glibc/newlib/picolibc extension was adopted where setting optind to zero causes the getopt state to be reset. Applications purely using the POSIX interface will not be affected by this, but the test cases will fail if the implementation does not support this extension. The only POSIX-compatible way to resolve that would be to split each test case into a separate test program. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
sys_getopt_r
branch
from
af750b9 to
3653dae
Compare
zephyrbot
requested review from
andyross,
cfriedt,
jukkar,
kartben,
rlubos and
thenguyenyf
Switch to the newlib-inspired API where users provide explicit storage for the getopt state. Signed-off-by: Keith Packard <[email protected]>
keith-packard
force-pushed
the
sys_getopt_r
branch
from
3653dae to
79c03fc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getopt APIs inspired by the re-entrant newlib/picolibc versions. Instead of stashing getopt state in global or thread-local variables, have callers allocate space for them instead.
The existing APIs remain available and unchanged, but all in-tree users are migrated to the new APIs and the documentation
refers to the new ones.
As a part of this work, the POSIX getopt implementation has been aligned with the POSIX standard as closely as possible; one minor extension has been adapted from glibc/newlib/picolibc to make re-use of the API possible in testing.